Clarify linker options in the guide are for GNU BFD #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesamesam
approved these changes
Jun 18, 2025
docs/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++.md
Outdated
Show resolved
Hide resolved
thomasnyman
force-pushed
the
linker-options-are-for-gnu-bfd
branch
2 times, most recently
from
c04b71f to
f0f605e
Compare
|
Addressed feedback and resolved conflicts with main in f0f605e. |
06kellyjac
approved these changes
Jun 19, 2025
| - supported both by the GCC and Clang / LLVM toolchains. | ||
| - cross-platform and supported on (at least) Intel and AMD 64-bit x86 architectures as well as the 64-bit version of the ARM architecture (AArch64). | ||
|
|
||
| Linker options covered by this guide are valid for the GNU BFD linker (LD) provided by Binutils (unless otherwise noted). |
There was a problem hiding this comment.
Suggested change
| Linker options covered by this guide are valid for the GNU BFD linker (LD) provided by Binutils (unless otherwise noted). | |
| Linker options covered by this guide are valid for tooling built off the GNU BFD (Binary File Descriptor) library (unless otherwise noted). Tools such as the GNU Linker (LD) and GNU Binary Utilities (binutils). |
There was a problem hiding this comment.
"GLD" isn't a commonly used term, and it's also ambiguous (could refer to the gold linker).
Co-authored-by: Jack Kelly <[email protected]> Co-authored-by: Sam James <[email protected]> Signed-off-by: Thomas Nyman <[email protected]>
thomasnyman
force-pushed
the
linker-options-are-for-gnu-bfd
branch
from
f0f605e to
1e39dca
Compare
|
Incorporated @06kellyjac's suggestion (with @thesamesam's clarification) in 1e39dca although I opted to flip the order so that we refer to ld primarily (as the sentence starts with mentioning linker options). Also added a trailing sentence to be more more specific that the options may not work with gold or lld. |
thesamesam
approved these changes
Jun 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #923